On Mon, Oct 01, 2018 at 04:31:38PM +0200, Jann Horn wrote: > As evidenced by the previous two patches, having two gigantic arrays that > must manually be kept in sync, including ifdefs, isn't exactly robust. > To make it easier to catch such issues in the future, add a BUILD_BUG_ON(). > > Signed-off-by: Jann Horn <jannh@xxxxxxxxxx> > --- > mm/vmstat.c | 2 ++ > 1 file changed, 2 insertions(+) I agree with Michal here, we had to do this long time ago. For patches 1-3: Acked-by: Roman Gushchin <guro@xxxxxx> BTW, don't we want to split this huge array into smaller parts? This will make the code more clear and easier to modify. Thank you!