On Sat, Sep 29, 2018 at 08:50:29AM +0800, Huang, Ying wrote: > Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> writes: > > The error handling in __swap_duplicate (before this series) still leaves > > something to be desired IMHO. Why all the different returns when callers > > ignore them or only specifically check for -ENOMEM or -EEXIST? Could maybe > > stand a cleanup, but outside this series. > > Yes. Maybe. I guess you will work on this? Sure, I'll see how it turns out.