On Thu 27-09-18 14:25:37, Oscar Salvador wrote: > On Thu, Sep 27, 2018 at 01:09:26PM +0200, Michal Hocko wrote: > > > So there were a few things I wasn't sure we could pull outside of the > > > hotplug lock. One specific example is the bits related to resizing the pgdat > > > and zone. I wanted to avoid pulling those bits outside of the hotplug lock. > > > > Why would that be a problem. There are dedicated locks for resizing. > > True is that move_pfn_range_to_zone() manages the locks for pgdat/zone resizing, > but it also takes care of calling init_currently_empty_zone() in case the zone is empty. > Could not that be a problem if we take move_pfn_range_to_zone() out of the lock? I would have to double check but is the hotplug lock really serializing access to the state initialized by init_currently_empty_zone? E.g. zone_start_pfn is a nice example of a state that is used outside of the lock. zone's free lists are similar. So do we really need the hoptlug lock? And more broadly, what does the hotplug lock is supposed to serialize in general. A proper documentation would surely help to answer these questions. There is way too much of "do not touch this code and just make my particular hack" mindset which made the whole memory hotplug a giant pile of mess. We really should start with some proper engineering here finally. -- Michal Hocko SUSE Labs
