On Mon, Sep 24, 2018 at 01:44:19PM +0200, Bartosz Golaszewski wrote: > pon., 24 wrz 2018 o 13:23 Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> napisał(a): > > > > On Mon, Sep 24, 2018 at 12:11:50PM +0200, Bartosz Golaszewski wrote: > > > Use devm_kstrdup_const() in the pmc-atom driver. This mostly serves as > > > an example of how to use this new routine to shrink driver code. > > > > > > While we're at it: replace a call to kcalloc() with devm_kcalloc(). > > > > > @@ -352,8 +344,6 @@ static int plt_clk_probe(struct platform_device *pdev) > > > goto err_drop_mclk; > > > } > > > > > > - plt_clk_free_parent_names_loop(parent_names, data->nparents); > > > - > > > platform_set_drvdata(pdev, data); > > > return 0; > > > > I don't think this is a good example. > > > > You changed a behaviour here in the way that you keep all chunks of memory > > (even small enough for pointers) during entire life time of the driver, which > > pretty likely would be forever till next boot. > > > > In the original case the memory was freed immediately in probe either it fails > > or returns with success. > > > > NAK, sorry. > > > > > > I see. > > I'd like to still merge patches 1-3 and then I'd come up with better > examples for the next release cycle once these are in? I'm fine with first three, though I can't come up with better example for you now. My previous comment solely to clk-pmc-atom code. -- With Best Regards, Andy Shevchenko
