On Wed, Sep 12, 2018 at 03:02:18PM +0100, Jonathan Cameron wrote: > Now I'm not sure what the preferred fix for this would be. > 1) Actually set the nid for each pfn during hot add rather than waiting for > online. > 2) Modify the whole call chain to pass the nid through as we know it at the > remove_memory call for hotplug cases... Hi Jonathan, I am back from vacation after four weeks, so I might still be in a bubble. I was cleaning up unregister_mem_sect_under_nodes in [1], but I failed to see this. I think that we can pass the node down the chain. Looking closer, we might be able to get rid of the nodemask var there, but I need to take a closer look. I had a RFCv2 sent a month ago [2] to fix another problem. That patchset, among other things, replaces the zone paramater with the nid. I was about to send a new version of that patchset, without RFC this time, so if you do not mind, I could add this change in there and you can comment it. What do you think? [1] https://patchwork.kernel.org/patch/10568547/ [2] https://patchwork.kernel.org/patch/10569085/ Thanks -- Oscar Salvador SUSE L3
