On Sat, Sep 01, 2018 at 02:38:43PM -0700, Linus Torvalds wrote: > On Fri, Aug 31, 2018 at 12:45 AM Julian Stecklina <jsteckli@xxxxxxxxx> wrote: > > > > I've been spending some cycles on the XPFO patch set this week. For the > > patch set as it was posted for v4.13, the performance overhead of > > compiling a Linux kernel is ~40% on x86_64[1]. The overhead comes almost > > completely from TLB flushing. If we can live with stale TLB entries > > allowing temporary access (which I think is reasonable), we can remove > > all TLB flushing (on x86). This reduces the overhead to 2-3% for > > kernel compile. > > I have to say, even 2-3% for a kernel compile sounds absolutely horrendous. > > Kernel bullds are 90% user space at least for me, so a 2-3% slowdown > from a kernel is not some small unnoticeable thing. Also the problem is that depending on the workload everything may fit into the TLBs, so the temporary stale TLB entries may be around for a long time. Modern CPUs have very large TLBs, and good LRU policies. For the kernel entries with global bit set and which are used for something there may be no reason ever to evict. Julian, I think you would need at least some quantitative perfmon data about TLB replacement rates in the kernel to show that it's "reasonable" instead of hand waving. Most likely I suspect you would need a low frequency regular TLB flush for the global entries at least, which will increase the overhead again. -Andi
