On Tue, 2011-03-15 at 14:52 +0530, Srikar Dronamraju wrote:
> * Stephen Wilson <wilsons@xxxxxxxx> [2011-03-14 14:09:14]:
>
Nitpick:
> Guess checking for tsk != NULL would only help if and only if we are doing
> within rcu. i.e we have to change to something like this
>
tsk = NULL;
> rcu_read_lock()
> if (mm->owner) {
> get_task_struct(mm->owner)
> tsk = mm->owner;
> }
> rcu_read_unlock()
> if (!tsk)
> return ret;
>
> Agree?
Or:
rcu_read_lock();
tsk = mm->owner;
if (tsk)
get_task_struct(tsk);
rcu_read_unlock();
if (!tsk)
return ret;
Probably looks cleaner.
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>