On Wed 29-08-18 09:28:21, Zi Yan wrote: [...] > This patch triggers WARN_ON_ONCE() in policy_node() when MPOL_BIND is used and THP is on. > Should this WARN_ON_ONCE be removed? > > > /* > * __GFP_THISNODE shouldn't even be used with the bind policy > * because we might easily break the expectation to stay on the > * requested node and not break the policy. > */ > WARN_ON_ONCE(policy->mode == MPOL_BIND && (gfp & __GFP_THISNODE)); This is really interesting. It seems to be me who added this warning but I cannot simply make any sense of it. Let me try to dig some more. -- Michal Hocko SUSE Labs
