On Mon, Aug 27, 2018 at 11:35 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Mon, Aug 27, 2018 at 09:01:48PM +0530, Souptick Joarder wrote: > > On Fri, Aug 3, 2018 at 6:44 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > > > > > On Fri, 3 Aug 2018, Souptick Joarder wrote: > > > > On Mon, Jul 16, 2018 at 2:47 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > > > > On Tue, 3 Jul 2018, Matthew Wilcox wrote: > > > > > > > > > >> Return vm_fault_t codes directly from the appropriate mm routines instead > > > > >> of converting from errnos ourselves. Fixes a minor bug where we'd return > > > > >> SIGBUS instead of the correct OOM code if we ran out of memory allocating > > > > >> page tables. > > > > >> > > > > >> Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxx> > > > > > > > > > > Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > > > > > > > > > > > > Thomas, are these 3 patches part of this series will be queued > > > > for 4.19 ? > > > > > > I don't know. I expected that these go through the mm tree, but if nobody > > > feels responsible, I could pick up the whole lot. But I'd like to see acks > > > from the mm folks for [1/3] and [3/3] > > > > > > https://lkml.kernel.org/r/20180703123910.2180-1-willy@xxxxxxxxxxxxx > > > > > > Thanks, > > > > > > tglx > > > > > > > Any comment from mm reviewers for patch [1/3] and [3/3] ?? > > > > https://lkml.kernel.org/r/20180703123910.2180-1-willy@xxxxxxxxxxxxx > > I think at this point, it would probably be best to ask Andrew to pick > up all three of these patches. Do we need to repost these three patches or lkml link https://lkml.kernel.org/r/20180703123910.2180-1-willy@xxxxxxxxxxxxx is fine to request Andrew ?? > In addition to these three, I see the following places that need to be changed: > > Documentation/gpu/drm-mm.rst:300: int (*fault)(struct vm_fault *vmf); ok, I will add this. > > drivers/gpu/drm/virtio/virtgpu_ttm.c:117:static int virtio_gpu_ttm_fault(struct vm_fault *vmf) > - #if 0 code. convert anyway. https://lkml.org/lkml/2018/7/2/795 Gerd Hoffmann, agreed to remove this dead code, but queued for 4.20. I think, this shouldn't be a blocker for us. > > drivers/gpu/drm/vkms/vkms_drv.h:68:int vkms_gem_fault(struct vm_fault *vmf); > drivers/gpu/drm/vkms/vkms_gem.c:46:int vkms_gem_fault(struct vm_fault *vmf) This was not queued for 4.19. Would you like to see this patch in 4.19-rc-x ? https://lkml.org/lkml/2018/7/30/767 > > fs/ext4/ext4.h:2472:extern int ext4_page_mkwrite(struct vm_fault *vmf); > fs/ext4/ext4.h:2473:extern int ext4_filemap_fault(struct vm_fault *vmf); > fs/ext4/inode.c:6154:int ext4_page_mkwrite(struct vm_fault *vmf) > fs/ext4/inode.c:6251:int ext4_filemap_fault(struct vm_fault *vmf) I have this patch ready in my local tree based on review comment from Ted. Ted was planning to take it in next merge window. I will post it on mailing list. > > fs/iomap.c:1059:int iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops) > include/linux/iomap.h:144:int iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops); > - I saw you just resent this patch. Now added to mm-tree. > mm/filemap.c:2751:int filemap_page_mkwrite(struct vm_fault *vmf) > - This is the NOMMU case, so I suspect your testing didn't catch it. Sorry, I missed it.
