Re: TLB flushes on fixmap changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Nadav Amit <nadav.amit@xxxxxxxxx>
Subject: Re: TLB flushes on fixmap changes
From: Andy Lutomirski <luto@xxxxxxxxxx>
Date: Mon, 27 Aug 2018 11:58:40 -0700
Cc: Andy Lutomirski <luto@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Jiri Kosina <jkosina@xxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, "the arch/x86 maintainers" <x86@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Rik van Riel <riel@xxxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Adin Scannell <ascannell@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, linux-mm <linux-mm@xxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>
In-reply-to: <0000D631-FDDF-4273-8F3C-714E6825E59B@gmail.com>
References: <D74A89DF-0D89-4AB6-8A6B-93BEC9A83595@gmail.com> <20180824180438.GS24124@hirez.programming.kicks-ass.net> <56A9902F-44BE-4520-A17C-26650FCC3A11@gmail.com> <CA+55aFzerzTPm94jugheVmWg8dJre94yu+GyZGT9NNZanNx_qw@mail.gmail.com> <9A38D3F4-2F75-401D-8B4D-83A844C9061B@gmail.com> <CA+55aFz1KYT7fRRG98wei24spiVg7u1Ec66piWY5359ykFmezw@mail.gmail.com> <8E0D8C66-6F21-4890-8984-B6B3082D4CC5@gmail.com> <CALCETrWdeKBcEs7zAbpEM1YdYiT2UBXwPtF0mMTvcDX_KRpz1A@mail.gmail.com> <20180826112341.f77a528763e297cbc36058fa@kernel.org> <CALCETrXPaX-+R6Z9LqZp0uOVmq-TUX_ksPbUL7mnfbdqo6z2AA@mail.gmail.com> <20180826090958.GT24124@hirez.programming.kicks-ass.net> <20180827120305.01a6f26267c64610cadec5d8@kernel.org> <4BF82052-4738-441C-8763-26C85003F2C9@gmail.com> <20180827170511.6bafa15cbc102ae135366e86@kernel.org> <01DA0BDD-7504-4209-8A8F-20B27CF6A1C7@gmail.com> <CALCETrWxwpr+Xx0mCK1HUkanmCDOSRbw50VmebgoAgeNaaPAKg@mail.gmail.com> <0000D631-FDDF-4273-8F3C-714E6825E59B@gmail.com>

On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit <nadav.amit@xxxxxxxxx> wrote:
>> On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit <nadav.amit@xxxxxxxxx> wrote:
>> What do you all think?
>
> I agree in general. But I think that current->mm would need to be loaded, as
> otherwise I am afraid it would break switch_mm_irqs_off().
>

What breaks?

Follow-Ups:
- Re: TLB flushes on fixmap changes
  - From: Nadav Amit

References:
- Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE
  - From: Nadav Amit
- Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE
  - From: Peter Zijlstra
- TLB flushes on fixmap changes
  - From: Nadav Amit
- Re: TLB flushes on fixmap changes
  - From: Linus Torvalds
- Re: TLB flushes on fixmap changes
  - From: Nadav Amit
- Re: TLB flushes on fixmap changes
  - From: Linus Torvalds
- Re: TLB flushes on fixmap changes
  - From: nadav . amit
- Re: TLB flushes on fixmap changes
  - From: Andy Lutomirski
- Re: TLB flushes on fixmap changes
  - From: Masami Hiramatsu
- Re: TLB flushes on fixmap changes
  - From: Andy Lutomirski
- Re: TLB flushes on fixmap changes
  - From: Peter Zijlstra
- Re: TLB flushes on fixmap changes
  - From: Masami Hiramatsu
- Re: TLB flushes on fixmap changes
  - From: Nadav Amit
- Re: TLB flushes on fixmap changes
  - From: Masami Hiramatsu
- Re: TLB flushes on fixmap changes
  - From: Nadav Amit
- Re: TLB flushes on fixmap changes
  - From: Andy Lutomirski
- Re: TLB flushes on fixmap changes
  - From: Nadav Amit

Prev by Date: Re: TLB flushes on fixmap changes
Next by Date: Re: [PATCH v6 1/2] mm: migration: fix migration of huge PMD shared pages
Previous by thread: Re: TLB flushes on fixmap changes
Next by thread: Re: TLB flushes on fixmap changes
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]