On Mon, 2011-03-14 at 22:54 +0530, Srikar Dronamraju wrote: > > > > I'm confused by the above comment and code. You state we are only > > interested text pages mapped read-only, but then if the page is mapped > > read/exec we exit out? It is fine if it is anything but READ/EXEC. > > You are right, it should have been > if ((vma->vm_flags & (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)) != > (VM_READ|VM_EXEC)) > goto put_out; > > Golden rule #12: When the comments do not match the code, they probably are both wrong ;) -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>