On Thu, Aug 23, 2018 at 09:17:29PM +0200, Michal Hocko wrote: > And how exactly does it help to check for the smaller vs. a larger number? > Both are O(1) operations AFAICS. __highest_present_section_nr makes > perfect sense when we iterate over all sections or similar operations > where it smaller number of iterations really makes sense. Sure, improvement/optimization was not really my point, a comparasion is a comparasion. The gain, if any, would be because we would catch non present sections sooner before calling to present_section(). In the case that __highest_present_section_nr differs from NR_MEM_SECTIONS, of course. I thought it would make more sense given the nature of the function itself. The only thing I did not like much was that we need to export the symbol, though. So, as you said, the price might be too hight for what we get. -- Oscar Salvador SUSE L3
