On Tue, Aug 14, 2018 at 11:39:34AM +0200, David Hildenbrand wrote: > On 13.08.2018 17:46, osalvador@xxxxxxxxxxxxxxxxxx wrote: > > From: Oscar Salvador <osalvador@xxxxxxx> > > While at it, we can also drop the node_online() check, as a node can only be > > offline if all the memory/cpus associated with it have been removed. > > I would prefer splitting this change out into a separate patch. Yes, I guess it is better as it is not really related to the changes in this patch. I will wait for more feedback and I will split it up in v3. > > + > > + if (unlinked_nodes) > > + NODEMASK_FREE(unlinked_nodes); > > NODEMASK_FEEE/kfree can deal with NULL pointers. Good point, I missed that. I will fix it up in v3. Thanks for reviewing. -- Oscar Salvador SUSE L3
