Re: [PATCH v2] mm: memcg: update memcg OOM messages on cgroup2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 06-08-18 13:19:07, Tejun Heo wrote:
> Hello, Michal.
> 
> On Mon, Aug 06, 2018 at 10:06:37PM +0200, Michal Hocko wrote:
> > Is there really any reason to have each couner on a seprate line? This
> > is just too much of an output for a single oom report. I do get why you
> > are not really thrilled by the hierarchical numbers but can we keep
> > counters in a single line please?
> 
> Hmm... maybe, but can you please consider the followings?
> 
> * It's the same information as memory.stat but would be in a different
>   format and will likely be a bit of an eyeful.
>
> * It can easily become a really long line.  Each kernel log can be ~1k
>   in length and there can be other limits in the log pipeline
>   (e.g. netcons).

Are we getting close to those limits?

> * The information is already multi-line and cgroup oom kills don't
>   take down the system, so there's no need to worry about scroll back
>   that much.  Also, not printing recursive info means the output is
>   well-bound.

Well, on the other hand you can have a lot of memcgs under OOM and then
swamp the log a lot.
-- 
Michal Hocko
SUSE Labs




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux