On 07/31/2018 04:50 PM, Oscar Salvador wrote: > On Tue, Jul 31, 2018 at 11:23:33AM -0400, Pavel Tatashin wrote: >> Yes we free meminit when no CONFIG_MEMORY_HOTPLUG >> See here: >> http://src.illumos.org/source/xref/linux-master/include/asm-generic/vmlinux.lds.h#107 > > Oh, I got the point now. > Somehow I missed that we were freeing up the memory when CONFIG_MEMORY_HOTPLUG > was not in place. > > So your patch makes sense to me now, sorry. > > Since my patchset [1] + cleanup patch [2] remove almost all __paginginit, > leaving only pgdat_init_internals() and zone_init_internals(), I think > it would be great if you base your patch on top of that. > Or since the patchset has some cleanups already, I could add your patch > into it (as we did for the zone_to/set_nid() patch) and send a v6 with it. > > What do you think? Sure, please go ahead include it in v6. Let me know if you need any help. Thank you for this work, I really like how this improves hotplug/memory-init code. Pavel > > [1] https://patchwork.kernel.org/patch/10548861/ > [2] <20180731101752.GA473@xxxxxxxxxxxxxxxxxx> > > Thanks >
