On Mon, Jul 23, 2018 at 04:23:39PM -0500, Richard Kuo wrote: > > On Mon, Jul 16, 2018 at 10:43:18AM +0300, Mike Rapoport wrote: > > This patch adds registration of the system memory with memblock, eliminates > > bootmem initialization and converts early memory reservations from bootmem > > to memblock. > > > > Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx> > > Sorry for the delay, and thanks for this patch. > > I think the first memblock_reserve should use ARCH_PFN_OFFSET instead of > PHYS_OFFSET. memblock_reserve gets physical address rather than a pfn. If I read arch/hexagon/include/asm/mem-layout.h correctly, the PHYS_OFFSET *is* the physical address of the RAM and ARCH_PFN_OFFSET is the first pfn: #define PHYS_PFN_OFFSET (PHYS_OFFSET >> PAGE_SHIFT) #define ARCH_PFN_OFFSET PHYS_PFN_OFFSET Did I miss something? > If you can amend that I'd be happy to take it through my tree or it can go > through any other. > > > Thanks, > Richard Kuo > > > -- > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sincerely yours, Mike.
