Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Thu, Jul 19, 2018 at 04:48:35PM +0800, Huang Ying wrote: >> +/* >> + * Determine the locking method in use for this device. Return >> + * swap_cluster_info if SSD-style cluster-based locking is in place. >> + */ >> static inline struct swap_cluster_info *lock_cluster_or_swap_info( >> struct swap_info_struct *si, >> unsigned long offset) >> { >> struct swap_cluster_info *ci; >> >> + /* Try to use fine-grained SSD-style locking if available: */ > > Once you touch this are can you also please use standard two-tab > alignment for the spill-over function arguments: > > static inline struct swap_cluster_info *lock_cluster_or_swap_info( > struct swap_info_struct *si, unsigned long offset) Sure. Will change this in next version. Best Regards, Huang, Ying