On Wed, Jul 18, 2018 at 10:11:50AM -0400, Pavel Tatashin wrote: > On 18-07-18 14:47:20, osalvador@xxxxxxxxxxxxxxxxxx wrote: > > From: Oscar Salvador <osalvador@xxxxxxx> > > > > Moving the #ifdefs out of the function makes it easier to follow. > > > > Signed-off-by: Oscar Salvador <osalvador@xxxxxxx> > > Hi Oscar, > > Reviewed-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx> > > Please include the following patch in your series, to get rid of the last > ifdef in this function. Hi Pavel, I am about to send v2 with this patch included, but I just wanted to let you know this: > + zone_set_nid(nid); This should be: zone_set_nid(zone, nid); I fixed it up in your patch, I hope that is ok. Thanks -- Oscar Salvador SUSE L3