On Wed, Jul 18, 2018 at 04:13:20PM -0700, Dave Hansen wrote: > On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > > + } else { > > + /* > > + * Reset __PHYSICAL_MASK. > > + * Maybe needed if there's inconsistent configuation > > + * between CPUs. > > + */ > > + physical_mask = (1ULL << __PHYSICAL_MASK_SHIFT) - 1; > > + } > > This seems like an appropriate place for a WARN_ON(). Either that, or > axe this code. There's pr_err_once() above in the function. -- Kirill A. Shutemov