On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > arch/x86/include/asm/mktme.h | 8 + > arch/x86/mm/init_64.c | 10 + > arch/x86/mm/mktme.c | 437 +++++++++++++++++++++++++++++++++++ > 3 files changed, 455 insertions(+) I'm not the maintainer. But, NAK from me on this on the diffstat alone. There is simply too much technical debt here. There is no way this code is not riddled with bugs and I would bet lots of beer on the fact that this has received little to know testing with all the combinations that matter, like memory hotplug. I'd love to be proven wrong, so I eagerly await to be dazzled with the test results that have so far escaped mention in the changelog. Please make an effort to refactor this to reuse the code that we already have to manage the direct mapping. We can't afford 455 new lines of page table manipulation that nobody tests or runs. How _was_ this tested?
