On Wed, Jul 18, 2018 at 03:36:47PM +0200, Michal Hocko wrote: > On Wed 18-07-18 14:47:21, osalvador@xxxxxxxxxxxxxxxxxx wrote: > > From: Oscar Salvador <osalvador@xxxxxxx> > > > > When free_area_init_core gets called from the memhotplug code, > > we only need to perform some of the operations in > > there. > > Which ones? Or other way around. Which we do not want to do and why? > > > Since memhotplug code is the only place where free_area_init_core > > gets called while node being still offline, we can better separate > > the context from where it is called. > > I really do not like this if node is offline than only perform half of > the function. This will generate more mess in the future. Why don't you > simply. If we can split out this code into logical units then let's do > that but no, please do not make random ifs for hotplug code paths. > Sooner or later somebody will simply don't know what is needed and what > is not. Yes, you are right. I gave it another thought and it was not a really good idea. Although I think the code from free_area_init_core can be simplified. I will try to come up with something that makes more sense. Thanks -- Oscar Salvador SUSE L3
