Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Lutomirski <luto@xxxxxxxxxx>
Subject: Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
From: Joerg Roedel <jroedel@xxxxxxx>
Date: Tue, 17 Jul 2018 09:05:44 +0200
Cc: Joerg Roedel <joro@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Jiri Kosina <jkosina@xxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, David Laight <David.Laight@xxxxxxxxxx>, Denys Vlasenko <dvlasenk@xxxxxxxxxx>, Eduardo Valentin <eduval@xxxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, "Liguori, Anthony" <aliguori@xxxxxxxxxx>, Daniel Gruss <daniel.gruss@xxxxxxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxx>, Andrea Arcangeli <aarcange@xxxxxxxxxx>, Waiman Long <llong@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, "David H . Gutteridge" <dhgutteridge@xxxxxxxxxxxx>
In-reply-to: <CALCETrUBR-TGPY7wF4UwRb7jW39H+rJ4XFen35dgJRysk9sYTQ@mail.gmail.com>
References: <1531308586-29340-1-git-send-email-joro@8bytes.org> <1531308586-29340-4-git-send-email-joro@8bytes.org> <823BAA9B-FACA-4E91-BE56-315FF569297C@amacapital.net> <20180713094849.5bsfpwhxzo5r5exk@8bytes.org> <CALCETrUP1QUKPLPJg6_L5=Mzmq33cSvq+NMaYW01wTCepdjCyg@mail.gmail.com> <CALCETrUBR-TGPY7wF4UwRb7jW39H+rJ4XFen35dgJRysk9sYTQ@mail.gmail.com>
User-agent: NeoMutt/20170421 (1.8.2)

On Fri, Jul 13, 2018 at 04:17:40PM -0700, Andy Lutomirski wrote:
> I re-read it again.  How about keeping TSS_entry_stack but making it
> be the offset from the TSS to the entry stack.  Then do the arithmetic
> in asm.

Hmm, I think its better to keep the arithmetic in the C file for better
readability. How about renaming it to TSS_entry2task_stack?

Regards,

	Joerg

Follow-Ups:
- Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
  - From: Andy Lutomirski

References:
- [PATCH 00/39 v7] PTI support for x86-32
  - From: Joerg Roedel
- [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
  - From: Joerg Roedel
- Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
  - From: Andy Lutomirski
- Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
  - From: Joerg Roedel
- Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
  - From: Andy Lutomirski
- Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
  - From: Andy Lutomirski

Prev by Date: Re: [PATCH v6 07/13] mm, madvise_inject_error: Let memory_failure() optionally take a page reference
Next by Date: Re: [PATCH 07/39] x86/entry/32: Enter the kernel via trampoline stack
Previous by thread: Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
Next by thread: Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]