On Fri, Jul 13, 2018 at 4:48 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> (But it would be interesting to see whether removing the check "fixes" it)
I'm building a "replace VM_BUG_ON() with proper printk's instead" right now.
Honestly, I think VM_BUG_ON() is complete garbage to begin with. We
know the code can't depend on it, since it's only enabled for VM
developers. And if it ever triggers, it doesn't get logged because the
machine is dead (since the VM code almost always holds critical
locks). So it's exactly the worst kind of BUG_ON.
Can we turn VM_BUG_ON() into "WARN_ON_ONCE()" and be done with it? The
VM developers will actually get better reports, and non-vm-developers
don't have dead machines.
Linus
