Re: [PATCH v5 5/5] mm/sparse: delete old sprase_init and enable new one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2018 at 5:09 AM Oscar Salvador
<osalvador@xxxxxxxxxxxxxxxxxx> wrote:
>
>
> > -#ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> > -static void __init sparse_early_mem_maps_alloc_node(void *data,
> > -                              unsigned long pnum_begin,
> > -                              unsigned long pnum_end,
> > -                              unsigned long map_count, int nodeid)
> > -{
> > -     struct page **map_map = (struct page **)data;
> > -
> > -     sparse_buffer_init(section_map_size() * map_count, nodeid);
> > -     sparse_mem_maps_populate_node(map_map, pnum_begin, pnum_end,
> > -                                      map_count, nodeid);
> > -     sparse_buffer_fini();
> > -}
>
> From now on, sparse_mem_maps_populate_node() is not being used anymore, so I guess we can just
> remove it from sparse.c, right? (as it is done in sparse-vmemmap.c).

Missed this one, even more code can be deleted! :) I will include this
in updated patches, after review comments.

Thank you,
Pavel

> --
> Oscar Salvador
> SUSE L3
>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux