> On Jul 11, 2018, at 4:29 AM, Joerg Roedel <joro@xxxxxxxxxx> wrote: > > From: Joerg Roedel <jroedel@xxxxxxx> > > The stack address doesn't need to be stored in tss.sp0 if > we switch manually like on sysenter. Rename the offset so > that it still makes sense when we change its location. > > We will also use this stack for all kernel-entry points, not > just sysenter. Reflect that in the name as well. Reviewed-by: Andy Lutomirski <luto@xxxxxxxxxx> But, if there’s another version, please fix this comment: > > > > /* Offset from the sysenter stack to tss.sp0 */ Here > - DEFINE(TSS_sysenter_sp0, offsetof(struct cpu_entry_area, tss.x86_tss.sp0) - > + DEFINE(TSS_entry_stack, offsetof(struct cpu_entry_area, tss.x86_tss.sp0) - > offsetofend(struct cpu_entry_area, entry_stack_page.stack)); > > #ifdef CONFIG_STACKPROTECTOR > -- > 2.7.4 >
