On Tue, 10 Jul 2018 07:56:04 +0800 Baoquan He <bhe@xxxxxxxxxx> wrote: > Hi Andrew, > > On 07/09/18 at 02:29pm, Andrew Morton wrote: > > On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin <pasha.tatashin@xxxxxxxxxx> wrote: > > > For the ease of review, I split this work so the first patch only adds new > > > interfaces, the second patch enables them, and removes the old ones. > > > > This clashes pretty significantly with patches from Baoquan and Oscar: > > > > mm-sparse-make-sparse_init_one_section-void-and-remove-check.patch > > mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix.patch > > mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix-2.patch > > mm-sparse-add-a-static-variable-nr_present_sections.patch > > mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch > > mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch > > > Is there duplication of intent here? Any thoughts on the > > prioritization of these efforts? > > The final version of my patches was posted here: > http://lkml.kernel.org/r/20180628062857.29658-1-bhe@xxxxxxxxxx > > Currently, only the first three patches are merged. > > mm-sparse-add-a-static-variable-nr_present_sections.patch > mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch > mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch > > They are preparation patches, and the 4th patch is the formal fix patch: > [PATCH v6 4/5] mm/sparse: Optimize memmap allocation during sparse_init() > > The 5th patch is a clean up patch according to reviewer's suggestion: > [PATCH v6 5/5] mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER > > I think Pavel's patches sits on top of all above five patches. OK, thanks, I've just moved to the v6 series.