On Mon, Jul 09, 2018 at 11:15:54PM +0900, Tetsuo Handa wrote: > On 2018/07/09 22:32, Matthew Wilcox wrote: > >> >From d6f24d6eecd79836502527624f8086f4e3e4c331 Mon Sep 17 00:00:00 2001 > >> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> > >> Date: Mon, 9 Jul 2018 15:58:44 +0900 > >> Subject: [PATCH] shmem: Fix crash upon xas_store() failure. > >> > >> syzbot is reporting list corruption [1]. This is because xas_store() from > >> shmem_add_to_page_cache() is not handling memory allocation failure. Fix > >> this by checking xas_error() after xas_store(). > > > > I have no idea why you wrote this patch on Monday when I already said > > I knew what the problem was on Friday, fixed the problem and pushed it > > out to my git tree on Saturday. > > > > Because syzbot found a C reproducer on 2018/07/09 02:29 UTC, and your fix was > not in time for a kernel version syzbot was testing, and you were not listed > as a recipient of this bug, and I didn't know you already fixed this bug. > > Anyway, linux-next-20180709 still does not have this fix. > What is the title of your fix you pushed on Saturday? I folded it into shmem: Convert shmem_add_to_page_cache to XArray. I can see it's fixed in today's linux-next. I fixed it differently from the way you fixed it, so if you're looking for an xas_error check after xas_store, you won't find it.
