On Thu, Jul 05, 2018 at 01:24:55PM -0700, Andrew Morton wrote: > On Thu, 5 Jul 2018 16:49:41 +0200 Johannes Thumshirn <jthumshirn@xxxxxxx> wrote: > > > On Thu, Jul 05, 2018 at 07:46:05AM -0700, Dan Williams wrote: > > > ...but that also allows 'echo "syncAndThenSomeGarbage" > > > > /sys/.../memmap_state' to succeed. > > > > Yep it does :-(. > > > > Damn > > sysfs_streq() Thanks! I didn't know that one existed. It's kind of a shame that we realised this was a problem and decided to solve it this way back in 2008 instead of realising that no driver actually cares whether there's a \n or not and stripping off the \n before the driver gets to see it. Probably too late to fix that now.
