Re: [memcg:akpm/pending-review/mm 42/55] mm/memcontrol.c:4416:3: error: implicit declaration of function 'mem_cgroup_id_remove'; did you mean 'mem_cgroup_under_move'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please ignore this build error. I am playing with a new mm git tracking
and the patch 0day pointed at is missing memcg-remove-memcg_cgroup-id-from-idr-on-mem_cgroup_css_alloc-failure.patch
dependency because Andrew marked that one for review so it is in a
different branch.

On Wed 04-07-18 19:21:55, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git akpm/pending-review/mm
> head:   175738392f8ada5ba7802ff7c5521d695c86f9fd
> commit: 253239b6fd036ed9367ed582de081300e7b256d4 [42/55] mm/workingset.c: refactor workingset_init()
> config: x86_64-randconfig-x004-201826 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout 253239b6fd036ed9367ed582de081300e7b256d4
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    mm/memcontrol.c: In function 'mem_cgroup_css_online':
> >> mm/memcontrol.c:4416:3: error: implicit declaration of function 'mem_cgroup_id_remove'; did you mean 'mem_cgroup_under_move'? [-Werror=implicit-function-declaration]
>       mem_cgroup_id_remove(memcg);
>       ^~~~~~~~~~~~~~~~~~~~
>       mem_cgroup_under_move
>    cc1: some warnings being treated as errors
> 
> vim +4416 mm/memcontrol.c
> 
> 0b8f73e1 Johannes Weiner  2016-01-20  4410  
> 73f576c0 Johannes Weiner  2016-07-20  4411  static int mem_cgroup_css_online(struct cgroup_subsys_state *css)
> 0b8f73e1 Johannes Weiner  2016-01-20  4412  {
> 58fa2a55 Vladimir Davydov 2016-10-07  4413  	struct mem_cgroup *memcg = mem_cgroup_from_css(css);
> 58fa2a55 Vladimir Davydov 2016-10-07  4414  
> cc77b3ae Kirill Tkhai     2018-07-04  4415  	if (memcg_alloc_shrinker_maps(memcg)) {
> cc77b3ae Kirill Tkhai     2018-07-04 @4416  		mem_cgroup_id_remove(memcg);
> cc77b3ae Kirill Tkhai     2018-07-04  4417  		return -ENOMEM;
> cc77b3ae Kirill Tkhai     2018-07-04  4418  	}
> cc77b3ae Kirill Tkhai     2018-07-04  4419  
> 73f576c0 Johannes Weiner  2016-07-20  4420  	/* Online state pins memcg ID, memcg ID pins CSS */
> 58fa2a55 Vladimir Davydov 2016-10-07  4421  	atomic_set(&memcg->id.ref, 1);
> 73f576c0 Johannes Weiner  2016-07-20  4422  	css_get(css);
> 2f7dd7a4 Johannes Weiner  2014-10-02  4423  	return 0;
> 8cdea7c0 Balbir Singh     2008-02-07  4424  }
> 8cdea7c0 Balbir Singh     2008-02-07  4425  
> 
> :::::: The code at line 4416 was first introduced by commit
> :::::: cc77b3ae444d49d3c2bbf7d321d51dad33f6aaef mm, memcg: assign memcg-aware shrinkers bitmap to memcg
> 
> :::::: TO: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx>
> :::::: CC: Michal Hocko <mhocko@xxxxxxxx>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
Michal Hocko
SUSE Labs




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux