Hi Kees, On Mon, Jul 2, 2018 at 8:44 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > On Sat, Jun 30, 2018 at 1:43 PM, Christoph von Recklinghausen > <crecklin@xxxxxxxxxx> wrote: > > The last issue I'm chasing is build failures on ARCH=m68k. The error is > > atomic_read and friends needed by the jump label code not being found. > > The config has CONFIG_BROKEN_ON_SMP=y, so the jump label calls I added > > will only be made #ifndef CONFIG_BROKEN_ON_SMP. Do you think that's > > worth a mention in the blurb that's added to > > Documentation/admin-guide/kernel-parameters.txt? > > Uhm, that's weird -- I think the configs on m68k need fixing then? I > don't want to have to sprinkle that ifdef in generic code. config BROKEN_ON_SMP bool depends on BROKEN || !SMP default y So BROKEN_ON_SMP=y if SMP=n, i.e. not an issue? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds