Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jia He <hejianet@xxxxxxxxx>
Subject: Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64
From: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
Date: Mon, 2 Jul 2018 23:03:01 -0400
Cc: linux@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, will.deacon@xxxxxxx, mark.rutland@xxxxxxx, hpa@xxxxxxxxx, Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>, AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx>, Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxxx>, Steven Sistare <steven.sistare@xxxxxxxxxx>, neelx@xxxxxxxxxx, erosca@xxxxxxxxxxxxxx, Vlastimil Babka <vbabka@xxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linux Memory Management List <linux-mm@xxxxxxxxx>, james.morse@xxxxxxx, Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>, steve.capper@xxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>, Philippe Ombredanne <pombredanne@xxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, kemi.wang@xxxxxxxxx, Petr Tesařík <ptesarik@xxxxxxxx>, yasu.isimatu@xxxxxxxxx, aryabinin@xxxxxxxxxxxxx, nborisov@xxxxxxxx, Wei Yang <richard.weiyang@xxxxxxxxx>, jia.he@xxxxxxxxxxxxxxxx
In-reply-to: <bfe24a3b-c982-9532-c05b-f42ebb77bbba@gmail.com>
References: <1530239363-2356-1-git-send-email-hejianet@gmail.com> <1530239363-2356-3-git-send-email-hejianet@gmail.com> <CAGM2reYn3ZbdjhcZze8Zt1eLNSdWghy0KwEXfd5xW+1Ba_SMbw@mail.gmail.com> <bfe24a3b-c982-9532-c05b-f42ebb77bbba@gmail.com>

Can you put it into memblock.c

> Do you think it looks ok if I add the inline prefix?

I would say no, this function is a too complex, and is not in some
critical path to be always inlined.

 I would put it into memblock.c, and have #ifdef
CONFIG_HAVE_MEMBLOCK_PFN_VALID around it.

Thank you,
Pavel

References:
- [PATCH v9 0/6] optimize memblock_next_valid_pfn and early_pfn_valid on arm and arm64
  - From: Jia He
- [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64
  - From: Jia He
- Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64
  - From: Pavel Tatashin
- Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64
  - From: Jia He

Prev by Date: [lkp-robot] ee410f15b1 BUG: kernel hang in boot stage
Next by Date: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim
Previous by thread: Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64
Next by thread: [PATCH v9 3/6] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]