Matthew Wilcox <willy@xxxxxxxxxxxxx> writes: > On Fri, Jun 29, 2018 at 09:17:16AM +0800, Huang, Ying wrote: >> Matthew Wilcox <willy@xxxxxxxxxxxxx> writes: >> > I'll take a look. Honestly, my biggest problem with this patch set is >> > overuse of tagging: >> > >> > 59832 Jun 22 Huang, Ying ( 131) [PATCH -mm -v4 00/21] mm, THP, swap: Swa >> > There's literally zero useful information displayed in the patch subjects. >> >> Thanks! What's your suggestion on tagging? Only keep "mm" or "swap"? > > Subject: [PATCH v14 10/74] xarray: Add XArray tags > > I'm not sure where the extra '-' in front of '-v4' comes from. I also > wouldn't put the '-mm' in front of it -- that information can live in > the cover letter's body rather than any patch's subject. > > I think 'swap:' implies "mm:", so yeah I'd just go with that. > > Subject: [PATCH v4 00/21] swap: Useful information here > > I'd see that as: > > 59832 Jun 22 Huang, Ying ( 131) [PATCH v4 00/21] swap: Useful informatio Looks good! I will use this naming convention in the future. > I had a quick look at your patches. I think only two are affected by > the XArray, and I'll make some general comments about them soon. Thanks! Best Regards, Huang, Ying
