On 07/01/2018 07:11 PM, kbuild test robot wrote: > Hi John, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v4.18-rc3] > [cannot apply to next-20180629] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125 > config: x86_64-randconfig-x010-201826 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > [...] > ^ > include/linux/compiler.h:58:42: note: in definition of macro '__trace_if' > if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ > ^~~~ >>> fs/f2fs/data.c:2021:4: note: in expansion of macro 'if' > if (!clear_page_dirty_for_io(page), wbc->sync_mode) > ^~ > fs/f2fs/data.c:2021:9: error: too few arguments to function 'clear_page_dirty_for_io' > if (!clear_page_dirty_for_io(page), wbc->sync_mode) > ^ > include/linux/compiler.h:69:16: note: in definition of macro '__trace_if' > ______r = !!(cond); \ > ^~~~ >>> fs/f2fs/data.c:2021:4: note: in expansion of macro 'if' > if (!clear_page_dirty_for_io(page), wbc->sync_mode) > ^~ > Typo, that should have been: if (!clear_page_dirty_for_io(page, wbc->sync_mode)) ...fixed locally, I'll include it in the next spin. (Somehow my last build didn't have all the filesystems enabled, sorry for the glitches.) thanks, -- John Hubbard NVIDIA
