On 06/29/2018 11:01 AM, Pavel Tatashin wrote: > Correct: it should be incremented on every iteration of the loop. No matter if the entries contained valid data or NULLs. So we increment in three places: > > if map_map[] has invalid entry, increment, continue > if usemap_map[] has invalid entry, increment, continue > at the end of the loop, everything was valid we increment it > > This is done so nr_consumed_maps does not get out of sync with the > current pnum. pnum does not equal to nr_consumed_maps, as there are > may be holes in pnums, but there is one-to-one correlation. Can this be made more clear in the code?