On Wed 20-06-18 15:36:45, David Rientjes wrote: [...] > That makes me think that "oom_notify_list" isn't very intuitive: it can > free memory as a last step prior to oom kill. OOM notify, to me, sounds > like its only notifying some callbacks about the condition. Maybe > oom_reclaim_list and then rename this to oom_reclaim_pages()? Yes agreed and that is the reason I keep saying we want to get rid of this yet-another-reclaim mechanism. We already have shrinkers which are the main source of non-lru pages reclaim. Why do we even need oom_reclaim_pages? What is fundamentally different here? Sure those pages should be reclaimed as the last resort but we already do have priority for slab shrinking so we know that the system is struggling when reaching the lowest priority. Isn't that enough to express the need for current oom notifier implementations? -- Michal Hocko SUSE Labs
