On Wed, Jun 20, 2018 at 08:25:51PM +0900, Tetsuo Handa wrote: > I'm hitting below lockdep warning (essentially same with > http://lkml.kernel.org/r/1518666178.6070.25.camel@xxxxxxxxx ) as of commit > ba4dbdedd3edc279 ("Merge tag 'jfs-4.18' of git://github.com/kleikamp/linux-shaggy") > on linux.git . I think that this became visible by commit 93781325da6e07af > ("lockdep: fix fs_reclaim annotation") which went to 4.18-rc1. What should we do? Fix the broken lockdep code? Superblock freeze level accounting is not a lock. By the time a freeze has got to the state where xfs_trans_alloc() would block, we've already frozen new data writes and drained all the dirty pages. Hence if the filesystem is frozen down to the transaction level, kswapd will never enter this path on the filesystem because there will be no dirty pages to write back. So this is a false positive. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
