Re: [PATCH V6 11/30] block: implement bio_pages_all() via bio_for_each_segment_all()

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH V6 11/30] block: implement bio_pages_all() via bio_for_each_segment_all()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 13 Jun 2018 07:44:12 -0700
Cc: Jens Axboe <axboe@xxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, David Sterba <dsterba@xxxxxxx>, Huang Ying <ying.huang@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Filipe Manana <fdmanana@xxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
In-reply-to: <20180609123014.8861-12-ming.lei@redhat.com>
References: <20180609123014.8861-1-ming.lei@redhat.com> <20180609123014.8861-12-ming.lei@redhat.com>
User-agent: Mutt/1.9.2 (2017-12-15)

Given that we have a single, dubious user of bio_pages_all I'd rather
see it as an opencoded bio_for_each_ loop in the caller.

Follow-Ups:
- Re: [PATCH V6 11/30] block: implement bio_pages_all() via bio_for_each_segment_all()
  - From: Ming Lei

References:
- [PATCH V6 00/30] block: support multipage bvec
  - From: Ming Lei
- [PATCH V6 11/30] block: implement bio_pages_all() via bio_for_each_segment_all()
  - From: Ming Lei