On Wed, Jun 13, 2018 at 09:26:54AM +0800, Huang, Ying wrote: > Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> writes: > > > On Tue, Jun 12, 2018 at 09:23:19AM +0800, Huang, Ying wrote: > >> Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> writes: > >> >> +#else > >> >> +static inline int __swap_duplicate_cluster(swp_entry_t *entry, > >> > > >> > This doesn't need inline. > >> > >> Why not? This is just a one line stub. > > > > Forgot to respond to this. The compiler will likely choose to optimize out > > calls to an empty function like this. Checking, this is indeed what it does in > > this case on my machine, with or without inline. > > Yes. I believe a decent compiler will inline the function in any way. > And it does no harm to keep "inline" too, Yes? Right, it does no harm, it's just a matter of style.
