On Tue, 12 Jun 2018 11:18:27 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Jun 12, 2018 at 12:16 AM Nicholas Piggin <npiggin@xxxxxxxxx> wrote:
> >
> > This brings the number of tlbiel instructions required by a kernel
> > compile from 33M to 25M, most avoided from exec->shift_arg_pages.
>
> And this shows that "page_start/end" is purely for powerpc and used
> nowhere else.
>
> The previous patch should have been to purely powerpc page table
> walking and not touch asm-generic/tlb.h
>
> I think you should make those changes to
> arch/powerpc/include/asm/tlb.h. If that means you can't use the
> generic header, then so be it.
I can make it ppc specific if nobody else would use it. But at least
mmu notifiers AFAIKS would rather use a precise range.
> Or maybe you can embed the generic case in some ppc-specific
> structures, and use 90% of the generic code just with your added
> wrappers for that radix invalidation on top.
Would you mind another arch specific ifdefs in there?
>
> But don't make other architectures do pointless work that doesn't
> matter - or make sense - for them.
Okay sure, and this is the reason for the wide cc list. Intel does
need it of course, from 4.10.3.1 of the dev manual:
— The processor may create a PML4-cache entry even if there are no
translations for any linear address that might use that entry
(e.g., because the P flags are 0 in all entries in the referenced
page-directory-pointer table).
But I'm sure others would not have paging structure caches at all
(some don't even walk the page tables in hardware right?). Maybe
they're all doing their own thing though.
Thanks,
Nick
