Re: [PATCHv2 00/24] Refactor sys_swapon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 4, 2011 at 5:54 PM, Cesar Eduardo Barros <cesarb@xxxxxxxxxx> wrote:
> Em 03-03-2011 13:15, Eric B Munson escreveu:
>>
>> On Tue, 01 Mar 2011, Cesar Eduardo Barros wrote:
>>
>>> This patch series refactors the sys_swapon function.
>>>
>>> sys_swapon is currently a very large function, with 313 lines (more than
>>> 12 25-line screens), which can make it a bit hard to read. This patch
>>> series reduces this size by half, by extracting large chunks of related
>>> code to new helper functions.
>>>
>>> One of these chunks of code was nearly identical to the part of
>>> sys_swapoff which is used in case of a failure return from
>>> try_to_unuse(), so this patch series also makes both share the same
>>> code.
>>>
>>> As a side effect of all this refactoring, the compiled code gets a bit
>>> smaller (from v1 of this patch series):
>>>
>>>    text       data        bss        dec        hex    filename
>>>   14012        944        276      15232       3b80
>>>  mm/swapfile.o.before
>>>   13941        944        276      15161       3b39
>>>  mm/swapfile.o.after
>>>
>>> The v1 of this patch series was lightly tested on a x86_64 VM.
>>
>> One more small suggestion, you should cc LKML on this series, as well as
>> any
>> of the other emails suggested by get_maintainer.pl.
>
> Should I resend the whole patch series with the correct Cc:?
>

I would and you can add my Tested-by: and Acked-by: to each patch as well.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]