Re: [PATCH v2] mm: Change return type int to vm_fault_t for fault handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 04, 2018 at 10:07:16AM +0530, Souptick Joarder wrote:
> On Sun, Jun 3, 2018 at 3:31 AM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> > On Sun, Jun 03, 2018 at 01:34:07AM +0530, Souptick Joarder wrote:
> >> @@ -3570,9 +3571,8 @@ static int hugetlb_cow(struct mm_struct *mm, struct vm_area_struct *vma,
> >>                       return 0;
> >>               }
> >>
> >> -             ret = (PTR_ERR(new_page) == -ENOMEM) ?
> >> -                     VM_FAULT_OOM : VM_FAULT_SIGBUS;
> >> -             goto out_release_old;
> >> +             ret = vmf_error(PTR_ERR(new_page));
> >> +                     goto out_release_old;
> >>       }
> >>
> >>       /*
> >
> > Something weird happened to the goto here
> 
> Didn't get it ? Do you refer to wrong indent in goto ?

Yes.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux