On Wed, May 30, 2018 at 10:55:29AM -0700, Darrick J. Wong wrote: > > + sector = xfs_fsb_to_db(ip, wpc->imap.br_startblock) + > > + ((offset - XFS_FSB_TO_B(mp, wpc->imap.br_startoff)) >> 9); > > " >> SECTOR_SHIFT" here? If so, I can fix this on its way in. The >> 9 that until very recently was used everywhere makes it nicely fit on two lines. But the fixup is ok with me, too.