On 23.05.2018 21:51, Christoph Hellwig wrote: > On Wed, May 23, 2018 at 05:11:51PM +0200, David Hildenbrand wrote: >> Kernel modules that want to control how/when memory is onlined/offlined >> need a proper interface to these functions. Also, for adding memory >> properly, memory_block_size_bytes is required. > > Which module? Please send it along with the enabling code. Hi, as indicated in the cover letter, it is called "virtio-mem". I sent it yesterday as a separate series (RFC). Cover letter: https://lkml.org/lkml/2018/5/23/800 Relevant patch: https://lkml.org/lkml/2018/5/23/803 > >> --- a/drivers/base/memory.c >> +++ b/drivers/base/memory.c >> @@ -88,6 +88,7 @@ unsigned long __weak memory_block_size_bytes(void) >> { >> return MIN_MEMORY_BLOCK_SIZE; >> } >> +EXPORT_SYMBOL(memory_block_size_bytes); > >> +EXPORT_SYMBOL(mem_hotplug_begin); > >> +EXPORT_SYMBOL(mem_hotplug_done); > > EXPORT_SYMBOL_GPL for any deep down VM internals, please. > I continued using what was being used for symbols in this file. If there are not other opinions, I'll switch to EXPORT_SYMBOL_GPL. Thanks! -- Thanks, David / dhildenb
