On Tue, 01 Mar 2011, Cesar Eduardo Barros wrote: > This patch series refactors the sys_swapon function. > > sys_swapon is currently a very large function, with 313 lines (more than > 12 25-line screens), which can make it a bit hard to read. This patch > series reduces this size by half, by extracting large chunks of related > code to new helper functions. > > One of these chunks of code was nearly identical to the part of > sys_swapoff which is used in case of a failure return from > try_to_unuse(), so this patch series also makes both share the same > code. > > As a side effect of all this refactoring, the compiled code gets a bit > smaller (from v1 of this patch series): > > text data bss dec hex filename > 14012 944 276 15232 3b80 mm/swapfile.o.before > 13941 944 276 15161 3b39 mm/swapfile.o.after > > The v1 of this patch series was lightly tested on a x86_64 VM. > > Changes from v1: > Rebased from v2.6.38-rc4 to v2.6.38-rc7. Aside from my preference to avoid likely/unlikely unless necessary, I don't see any problems with this series. Acked-by: Eric B Munson <emunson@xxxxxxxxx> For the entire series
Attachment:
signature.asc
Description: Digital signature