On Tue, May 15, 2018 at 08:47:25AM -0500, Goldwyn Rodrigues wrote: > On 05/15/2018 02:26 AM, Christoph Hellwig wrote: > > On Mon, May 14, 2018 at 11:00:08AM -0500, Goldwyn Rodrigues wrote: > >>> + if (iop || i_blocksize(inode) == PAGE_SIZE) > >>> + return iop; > >> > >> Why is this an equal comparison operator? Shouldn't this be >= to > >> include filesystem blocksize greater than PAGE_SIZE? > > > > Which filesystems would that be that have a tested and working PAGE_SIZE > > support using iomap? > > Oh, I assumed iomap would work for filesystems with block size greater > than PAGE_SIZE. It will eventually, but first we've got to remove the iomap infrastructure and filesystem dependencies on bufferheads.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
