On Thu, May 10, 2018 at 08:08:38AM -0700, Darrick J. Wong wrote: > > > > + sector_t *bno = data; > > > > + > > > > + if (iomap->type == IOMAP_MAPPED) > > > > + *bno = (iomap->addr + pos - iomap->offset) >> inode->i_blkbits; > > > > > > Does this need to be careful w.r.t. overflow on systems where sector_t > > > is a 32-bit unsigned long? > > > > > > Also, ioctl_fibmap() typecasts the returned sector_t to an int, which > > > also seems broken. I agree the interface needs to die, but ioctls take > > > a long time to deprecate. > > > > Not much we can do about the interface. > > Yes, the interface is fubar, but if file /foo maps to block 8589934720 > then do we return the truncated result 128? Then we'll get a corrupt result. What do you think we could do here eithere in the old or new code?
