Re: [PATCH] mm/memory_hotplug: Fix leftover use of struct page during hotplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 04-05-18 17:50:51, Jonathan Cameron wrote:
[...]
> Exact path to the problem is as follows:
> 
> mm/memory_hotplug.c : add_memory_resource
> The node is not online so we enter the
> if (new_node) twice, on the second such block there is a call to
> link_mem_sections which calls into
> drivers/node.c: link_mem_sections which calls
> drivers/node.c: register_mem_sect_under_node which calls
> get_nid_for_pfn and keeps trying until the output of that matches
> the expected node (passed all the way down from add_memory_resource)

I am sorry but I am still confused. Why don't we create sysfs files from
__add_pages
  __add_section
    hotplug_memory_register
      register_mem_sect_under_node

The whole sysfs mess just deserves to die and be reworked completely.
Creating different pieces here and there is just a recipe for bugs
and unreviewable code </rant>
-- 
Michal Hocko
SUSE Labs




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux