Re: [External] Re: [PATCH 3/3] mm/page_alloc: Fix typo in debug info of calculate_node_totalpages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Huaisheng HS1 Ye <yehs1@xxxxxxxxxx>
Subject: Re: [External] Re: [PATCH 3/3] mm/page_alloc: Fix typo in debug info of calculate_node_totalpages
From: Michal Hocko <mhocko@xxxxxxxxxx>
Date: Wed, 9 May 2018 09:48:57 +0200
Cc: "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "vbabka@xxxxxxx" <vbabka@xxxxxxx>, "mgorman@xxxxxxxxxxxxxxxxxxx" <mgorman@xxxxxxxxxxxxxxxxxxx>, "pasha.tatashin@xxxxxxxxxx" <pasha.tatashin@xxxxxxxxxx>, "alexander.levin@xxxxxxxxxxx" <alexander.levin@xxxxxxxxxxx>, "hannes@xxxxxxxxxxx" <hannes@xxxxxxxxxxx>, "penguin-kernel@xxxxxxxxxxxxxxxxxxx" <penguin-kernel@xxxxxxxxxxxxxxxxxxx>, "colyli@xxxxxxx" <colyli@xxxxxxx>, NingTing Cheng <chengnt@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <HK2PR03MB16841DAC9D4C5D0569676F7692850@HK2PR03MB1684.apcprd03.prod.outlook.com>
References: <1525416729-108201-1-git-send-email-yehs1@lenovo.com> <1525416729-108201-4-git-send-email-yehs1@lenovo.com> <20180504131854.GQ4535@dhcp22.suse.cz> <HK2PR03MB16841DAC9D4C5D0569676F7692850@HK2PR03MB1684.apcprd03.prod.outlook.com>
User-agent: Mutt/1.9.5 (2018-04-13)

On Sat 05-05-18 02:10:35, Huaisheng HS1 Ye wrote:
[...]
> But this printk is a relatively meaningful reference within dmesg log.
> Especially for people who doesn't have much experience, or someone
> has a plan to modify boundary of zones within free_area_init_*.

Could you be more specific please? I am not saying that the printk is
pointless but it is DEBUG and as such it doesn't give us a very good
picture.

-- 
Michal Hocko
SUSE Labs

References:
- [PATCH 0/3] Some fixes for mm code optimization
  - From: Huaisheng Ye
- Re: [PATCH 3/3] mm/page_alloc: Fix typo in debug info of calculate_node_totalpages
  - From: Michal Hocko
- RE: [External] Re: [PATCH 3/3] mm/page_alloc: Fix typo in debug info of calculate_node_totalpages
  - From: Huaisheng HS1 Ye

Prev by Date: [PATCH 06/33] mm: give the 'ret' variable a better name __do_page_cache_readahead
Next by Date: [PATCH 07/33] mm: split ->readpages calls to avoid non-contiguous pages lists
Previous by thread: RE: [External] Re: [PATCH 3/3] mm/page_alloc: Fix typo in debug info of calculate_node_totalpages
Next by thread: Re: [PATCH 2/3] include/linux/gfp.h: use unsigned int in gfp_zone
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]