Le mercredi 02 mars 2011 Ã 10:46 +0800, Lai Jiangshan a Ãcrit : > Is it the cause of false sharing? I thought that all are rare write(except __refcnt) > since it is protected by RCU. > > Do you allow me just move the seldom access rcu_head to the end of the structure > and add pads before __refcnt? I guess it increases about 3% the size of dst_entry. dst_entry is a base class. Its included at the beginning of other structs. Moving rcu_head "at the end" just move it right in the middle of upper objects as a matter of fact. This might add one cache line miss on critical network object. A complete audit is needed. David is doing some changes in this area, so things move fast anyway. > I accept that I leave this code as is, when I change rcu_head I will notify you. > Thanks -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>