This patch makes mm to have capability to get special regions from memblock. During boot process, memblock marks NVDIMM regions with flag MEMBLOCK_NVDIMM, also expands the interface of functions and macros with flags. Signed-off-by: Huaisheng Ye <yehs1@xxxxxxxxxx> Signed-off-by: Ocean He <hehy1@xxxxxxxxxx> --- include/linux/memblock.h | 19 +++++++++++++++++++ mm/memblock.c | 46 +++++++++++++++++++++++++++++++++++++++++----- 2 files changed, 60 insertions(+), 5 deletions(-) diff --git a/include/linux/memblock.h b/include/linux/memblock.h index f92ea77..cade5c8d 100644 --- a/include/linux/memblock.h +++ b/include/linux/memblock.h @@ -26,6 +26,8 @@ enum { MEMBLOCK_HOTPLUG = 0x1, /* hotpluggable region */ MEMBLOCK_MIRROR = 0x2, /* mirrored region */ MEMBLOCK_NOMAP = 0x4, /* don't add to kernel direct mapping */ + MEMBLOCK_NVDIMM = 0x8, /* NVDIMM region */ + MEMBLOCK_MAX_TYPE = 0x10 /* all regions */ }; struct memblock_region { @@ -89,6 +91,8 @@ bool memblock_overlaps_region(struct memblock_type *type, int memblock_mark_mirror(phys_addr_t base, phys_addr_t size); int memblock_mark_nomap(phys_addr_t base, phys_addr_t size); int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); +int memblock_mark_nvdimm(phys_addr_t base, phys_addr_t size); +int memblock_clear_nvdimm(phys_addr_t base, phys_addr_t size); ulong choose_memblock_flags(void); /* Low level functions */ @@ -167,6 +171,11 @@ void __next_reserved_mem_region(u64 *idx, phys_addr_t *out_start, i != (u64)ULLONG_MAX; \ __next_reserved_mem_region(&i, p_start, p_end)) +static inline bool memblock_is_nvdimm(struct memblock_region *m) +{ + return m->flags & MEMBLOCK_NVDIMM; +} + static inline bool memblock_is_hotpluggable(struct memblock_region *m) { return m->flags & MEMBLOCK_HOTPLUG; @@ -187,6 +196,11 @@ int memblock_search_pfn_nid(unsigned long pfn, unsigned long *start_pfn, unsigned long *end_pfn); void __next_mem_pfn_range(int *idx, int nid, unsigned long *out_start_pfn, unsigned long *out_end_pfn, int *out_nid); +void __next_mem_pfn_range_with_flags(int *idx, int nid, + unsigned long *out_start_pfn, + unsigned long *out_end_pfn, + int *out_nid, + unsigned long flags); /** * for_each_mem_pfn_range - early memory pfn range iterator @@ -201,6 +215,11 @@ void __next_mem_pfn_range(int *idx, int nid, unsigned long *out_start_pfn, #define for_each_mem_pfn_range(i, nid, p_start, p_end, p_nid) \ for (i = -1, __next_mem_pfn_range(&i, nid, p_start, p_end, p_nid); \ i >= 0; __next_mem_pfn_range(&i, nid, p_start, p_end, p_nid)) + +#define for_each_mem_pfn_range_with_flags(i, nid, p_start, p_end, p_nid, flags) \ + for (i = -1, __next_mem_pfn_range_with_flags(&i, nid, p_start, p_end, p_nid, flags);\ + i >= 0; __next_mem_pfn_range_with_flags(&i, nid, p_start, p_end, p_nid, flags)) + #endif /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */ /** diff --git a/mm/memblock.c b/mm/memblock.c index 48376bd..7699637 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -771,6 +771,16 @@ int __init_memblock memblock_clear_hotplug(phys_addr_t base, phys_addr_t size) return memblock_setclr_flag(base, size, 0, MEMBLOCK_HOTPLUG); } +int __init_memblock memblock_mark_nvdimm(phys_addr_t base, phys_addr_t size) +{ + return memblock_setclr_flag(base, size, 1, MEMBLOCK_NVDIMM); +} + +int __init_memblock memblock_clear_nvdimm(phys_addr_t base, phys_addr_t size) +{ + return memblock_setclr_flag(base, size, 0, MEMBLOCK_NVDIMM); +} + /** * memblock_mark_mirror - Mark mirrored memory with flag MEMBLOCK_MIRROR. * @base: the base phys addr of the region @@ -891,6 +901,10 @@ void __init_memblock __next_mem_range(u64 *idx, int nid, ulong flags, if (nid != NUMA_NO_NODE && nid != m_nid) continue; + /* skip nvdimm memory regions if needed */ + if (!(flags & MEMBLOCK_NVDIMM) && memblock_is_nvdimm(m)) + continue; + /* skip hotpluggable memory regions if needed */ if (movable_node_is_enabled() && memblock_is_hotpluggable(m)) continue; @@ -1007,6 +1021,10 @@ void __init_memblock __next_mem_range_rev(u64 *idx, int nid, ulong flags, if (nid != NUMA_NO_NODE && nid != m_nid) continue; + /* skip nvdimm memory regions if needed */ + if (!(flags & MEMBLOCK_NVDIMM) && memblock_is_nvdimm(m)) + continue; + /* skip hotpluggable memory regions if needed */ if (movable_node_is_enabled() && memblock_is_hotpluggable(m)) continue; @@ -1070,12 +1088,9 @@ void __init_memblock __next_mem_range_rev(u64 *idx, int nid, ulong flags, } #ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP -/* - * Common iterator interface used to define for_each_mem_range(). - */ -void __init_memblock __next_mem_pfn_range(int *idx, int nid, +void __init_memblock __next_mem_pfn_range_with_flags(int *idx, int nid, unsigned long *out_start_pfn, - unsigned long *out_end_pfn, int *out_nid) + unsigned long *out_end_pfn, int *out_nid, unsigned long flags) { struct memblock_type *type = &memblock.memory; struct memblock_region *r; @@ -1085,6 +1100,16 @@ void __init_memblock __next_mem_pfn_range(int *idx, int nid, if (PFN_UP(r->base) >= PFN_DOWN(r->base + r->size)) continue; + + /* + * Use "flags & r->flags " to find region with multi-flags + * Use "flags == r->flags" to include region flags of MEMBLOCK_NONE + * Set flags = MEMBLOCK_MAX_TYPE to ignore to check flags + */ + + if ((flags != MEMBLOCK_MAX_TYPE) && (flags != r->flags) && !(flags & r->flags)) + continue; + if (nid == MAX_NUMNODES || nid == r->nid) break; } @@ -1101,6 +1126,17 @@ void __init_memblock __next_mem_pfn_range(int *idx, int nid, *out_nid = r->nid; } +/* + * Common iterator interface used to define for_each_mem_range(). + */ +void __init_memblock __next_mem_pfn_range(int *idx, int nid, + unsigned long *out_start_pfn, + unsigned long *out_end_pfn, int *out_nid) +{ + __next_mem_pfn_range_with_flags(idx, nid, out_start_pfn, out_end_pfn, + out_nid, MEMBLOCK_MAX_TYPE); +} + /** * memblock_set_node - set node ID on memblock regions * @base: base of area to set node ID for -- 1.8.3.1